Incompatible change for lowercase? and uppercase? #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backwards-incompatible change and will be followed by a commit to
increment the major version of the strings package.
It's unintuitive for `lowercase?('8')` to return `#t` since being lowercase
implies being alphabetic, and similarly for `uppercase?`. So this change makes
both `lowercase?('8')` and `uppercase?('8')` return `#f`.
What exactly `lowercase?("f8")` should mean is less clear, but as a member of
the generic function it should match the method on `<character>` which, I
believe, implies that it should be equivalent to `every?(lowercase?, string)`.
Because the implementation is trivial and because I can't think of a common use
case for this method, I'm removing it entirely and making this a non-generic
function.
This works better with the Furo theme.
housel
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incompatible change for lowercase? and uppercase?