wip! reserved keywords #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor: see dylibso/xtp-bindgen#18 * Support nullable vs required
bhelx
approved these changes
Nov 20, 2024
Contributor
bhelx
left a comment
bhelx
left a comment
There was a problem hiding this comment.
Looks good to me. I like not littering the code with r# everywhere!
chrisdickinson
force-pushed
the
chris/20241120-reserved-keywords
branch
from
7f2e117 to
91bcde3
Compare
Author
|
Thanks! I pushed up one more change that handles the (off-chance) that someone uses a reserved word as an export ( (Edit: and rebased on top of #16) |
|
This looks good to me! I am planning to look into why tests are failing this afternoon |
zshipko
approved these changes
Nov 20, 2024
zshipko
left a comment
zshipko
left a comment
There was a problem hiding this comment.
I just pushed a commit that fixes the bindgen tests locally, but not on CI 😞
We can merge this and I can debug CI on another branch
This was referenced Nov 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick rev on #17 – we can throw it away if we like!
(Additionally, I switched us over to
serde_json::Mapfromstd::collections::HashMap.)I haven't tested these, but I can do so after rebasing on #16 if we're interested in this!