Feature/14 error on missing api key#23
Merged
Merged
Conversation
morehavoc
reviewed
Sep 14, 2022
| if (string.IsNullOrWhiteSpace(ApiKey) && (AllowDefaultEsriLogin is null || !AllowDefaultEsriLogin.Value)) | ||
| { | ||
| ErrorMessage = "No ArcGIS API Key Found. See UsingTheAPI.md for instructions on providing an API Key or suppressing this message."; | ||
| #if DEBUG |
Member
There was a problem hiding this comment.
Should we really put the entire if block inside the #if DEBUG? Since all we are doing is the print, there's no point in even checking if we are not in DEBUG.
morehavoc
approved these changes
Sep 22, 2022
Member
morehavoc
left a comment
morehavoc
left a comment
There was a problem hiding this comment.
See Comment about #IF DEBUG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14
UsingTheAPI.mddocumentation file.MainLayout.razorfor implementing OAuth login.We will create a separate gissue for a more thorough OAuth implementation.