Feature/29 namespaces#32
Conversation
seahro
left a comment
seahro
left a comment
There was a problem hiding this comment.
The Blazor.GIS.API changes to GeoBlazor look good. I see there were a couple other adjustments that I saw were refactorings. They seemed like simple adjustments. Looks good
| */dymaptic.Blazor.GIS.API.Core.Sample.Shared/wwwroot/pages | ||
| */dymaptic.Blazor.GIS.API.Core.Sample.Wasm/dymaptic.Blazor.GIS.API.Core.Sample.Wasm.csproj.user | ||
| */dymaptic.Blazor.GIS.API.Core.Sample.Maui/Resources/Raw/*.html | ||
| */dymaptic.GeoBlazor.Core.Sample.Shared/wwwroot/pages |
There was a problem hiding this comment.
Replacing all Blazor.GIS.API references with GeoBlazor
| </div> | ||
| <div class="form-group"> | ||
| <label>Scale Bar: <input type="checkbox" @onchange="@(() => ToggleWidget(nameof(ScaleBarWidget)))"></label> | ||
| </div> |
There was a problem hiding this comment.
I guess this was the only real additions were line6? line 25/26?
There was a problem hiding this comment.
Thanks for catching/pointing this out. It's actually local changes that belong on #17. I'll revert them here.
|
@seahro I must have accidentally based this branch off |
# Conflicts: # ReadMe.md # UsingTheAPI.md # samples/dymaptic.GeoBlazor.Core.Sample.Shared/Pages/Test.razor # src/dymaptic.GeoBlazor.Core/Components/MapComponent.razor.cs # src/dymaptic.GeoBlazor.Core/Exceptions/MissingRequiredChildElementException.cs # src/dymaptic.GeoBlazor.Core/RequiredPropertyAttribute.cs
|
Well, undoing those changes here made the merge in from that branch even messier. But, I think I've got it all squared away, and I have re-tested, both manually and with the playwright tests. |
2 participants
This is changing all file names, folder names, and text references from
dymaptic.Blazor.GIS.API.Coretodymaptic.GeoBlazor.Core. Note that we definitely need to increment the version along with this, I'll push that in the morning, but just getting this PR started.