Open
Conversation
Without `.unref` a timeout can prevent a process from closing. This isn't the intent of the timeout, and it can manifest in issues if tinypg is used in the context of test runners. This also requires a bump to the node types, since unref was added in node 9. The project claims to require node 14 so bumping to v9 is not out of scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the timeouts could prevent processes from being closed.
This fix requires a bump to the node types, since
unrefwas added in node 9. The project claims to require node 14 so bumping to v9 is not out of scope.Resolves #46