Skip to content

Conversation

@ianwilk20
Copy link
Collaborator

New Features:

  • Added isChild prop to the 'ProgressBar' component since that is the only way to pass an aria-label

ℹ️ Related Issues:

n/a

📷 Screenshots:
image

@ianwilk20 ianwilk20 requested a review from dynamic11 May 3, 2022 21:09
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #97 (d9b62dc) into master (10d5f55) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines          402       403    +1     
  Branches       229       230    +1     
=========================================
+ Hits           402       403    +1     
Impacted Files Coverage Δ
src/components/ProgressBar/ProgressBar.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10d5f55...d9b62dc. Read the comment docs.

@ianwilk20 ianwilk20 requested a review from Rizvida1 May 3, 2022 22:30
@ianwilk20 ianwilk20 merged commit 7ef15d1 into master May 4, 2022
@ianwilk20 ianwilk20 deleted the ian-add-ability-to-pass-aria-label-to-progress-bar branch May 4, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants