Fix VAT Group prices and Expose Connector#64
Merged
DWDBE merged 8 commits intoMay 13, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Live Integration pricing to correctly derive VAT-inclusive amounts when the ERP response omits TotalPriceWithVat (notably for VAT Group pricing), and exposes the Connector API for extensibility scenarios.
Changes:
- Extends
GetPriceInfoto accept theProductinstance and uses it when calculating VAT-inclusive prices viaPriceCalculated. - Updates price-provider call sites and example override to use the new
GetPriceInfooverload (keeps the old overload as[Obsolete]). - Makes
Connectors.Connectorpublic (and exposesRetrievePDFpublicly) and bumps package version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Products/ProductProviderBase.cs | Adds new GetPriceInfo overload carrying Product through VAT calculation path; retains obsolete overload. |
| src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Products/ProductPriceProvider.cs | Updates callers to pass Product into the new pricing APIs. |
| src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Dynamicweb.Ecommerce.DynamicwebLiveIntegration.csproj | Version bump 10.4.35 → 10.4.36. |
| src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Connectors/Connector.cs | Exposes Connector publicly and makes RetrievePDF public for extensibility. |
| src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration.Examples/CustomProductProvider.cs | Updates example override to the new GetPriceInfo signature. |
Comments suppressed due to low confidence (1)
src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Connectors/Connector.cs:363
RetrievePDFis nowpublic, but it has no XML documentation while the other public methods in this class do. Add a<summary>(and relevant<param>/<returns>tags) so the newly public API is documented consistently.
public static string RetrievePDF(Settings settings, string requestString, SubmitType submitType)
{
Diagnostics.ExecutionTable.Current.Add("DynamicwebLiveIntegration.Connector.RetrievePDF START");
string base64EncodedPDF;
var logger = new Logger(settings);
try
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…on references from 'product' to 'productInfo' Agent-Logs-Url: https://github.com/dynamicweb/DataIntegration.LiveIntegration/sessions/109a717e-4ead-4d8d-98c7-26b0c32530f2 Co-authored-by: MatthiasSort <123721955+MatthiasSort@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Connectors/Connector.cs:363
- RetrievePDF is now a public API surface, but it doesn't have XML documentation while the other public methods on Connector do. Add
// docs (and, if relevant, document that it logs the request/response and rethrows on errors) to keep the public API consistent and discoverable.
public static string RetrievePDF(Settings settings, string requestString, SubmitType submitType)
{
Diagnostics.ExecutionTable.Current.Add("DynamicwebLiveIntegration.Connector.RetrievePDF START");
string base64EncodedPDF;
var logger = new Logger(settings);
try
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
MatthiasSort
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#28202: Fix product prices for the VAT Group (when no ProductPriceWithVat value is in the response xml)
#28164: Expose Connector for extensibility use