feat!: Migrate to Arcanist-compatible configuration#174
Merged
Conversation
Read .arcconfig from git repo root for PHAB_URL, write credentials to ~/.arcrc instead of phabfive.yaml, and deprecate PHAB_URL/PHAB_TOKEN in ~/.config/phabfive.yaml with warnings guiding users to migrate. When PHAB_URL is missing, offer to create .arcconfig instead of running the full ~/.arcrc setup wizard. Env-var PHAB_URL is peeked at before .arcrc loading so multi-host .arcrc works with env overrides. Closes #171, closes #172, closes #173 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
671d2e3 to
3d52710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.arcconfigfrom git repo root forPHAB_URL(viaphabricator.uri)phabfive user setup) now writes credentials to~/.arcrcin Arcanist-compatible JSON format instead of~/.config/phabfive.yamlPHAB_URL/PHAB_TOKENin~/.config/phabfive.yamlwithDeprecationWarningguiding users to migratePHAB_URLis missing, offer to create.arcconfiginstead of running the full~/.arcrcsetup wizardPHAB_URLis peeked at before.arcrcloading so multi-host~/.arcrcworks with env overridesBackwards incompatibility
This is not a breaking change in the strict sense — existing configurations continue to work. However it is backwards incompatible in these ways:
phabfive user setupnow writes to~/.arcrc(JSON) instead of~/.config/phabfive.yaml(YAML). Users who re-run setup will get credentials in the new location.PHAB_URL/PHAB_TOKENin~/.config/phabfive.yamlwill see deprecation warnings on stderr.PHAB_URLnow suggests creating.arcconfiginstead of editingphabfive.yaml.New config precedence
Test plan
uv run pytest— 330 tests passuv run ruff check— cleanPHAB_URL=... phabfive user whoamiworks in empty directory with multi-host~/.arcrcphabfive user setupcreates/updates~/.arcrcin correct JSON format.arcconfigin a git repo root, verify phabfive readsphabricator.uriPHAB_URLin~/.config/phabfive.yaml, verify deprecation warning appearsCloses #171, closes #172, closes #173
🤖 Generated with Claude Code