Skip to content
This repository was archived by the owner on Sep 22, 2024. It is now read-only.

Conversation

@Philipose
Copy link
Member

No description provided.

@Philipose
Copy link
Member Author

Functions should be ready. Test cases are needed

@Philipose
Copy link
Member Author

Currently 100% Test Coverage.

Adding capability to import user variables from YAML or JSON.
Added capabilities to programmatically add clusters. Currently one of the functions only supported reference to cluster by name.

Current to-do left:
Adjust request_handler to allow cluster to be a string and pull from the settings file if a string is provided instead

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Philipose Philipose marked this pull request as ready for review February 22, 2021 03:20
@Philipose
Copy link
Member Author

Later we will want to revisit removing user_variables approach altogether but for not it's simply adapted @radu-stefan-dt

@Philipose Philipose merged commit df0ebc0 into dev Feb 22, 2021
@Philipose Philipose deleted the PAF-44_Settings_Rework branch February 22, 2021 03:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants