Closed
Conversation
If the changed function reference the weak symbol, when loading the patch module will trigger the following error: module kpatch-***: overflow in relocation type *** val 0 insmod: can't insert 'kpatch-***.ko': invalid module format This patch fix it. Signed-off-by: Li Bin <huawei.libin@huawei.com>
Before this patch, if changed function is weak symbol, it is not be allowed to create live patch, and it will trigger the following error: /usr/local/libexec/kpatch/create-diff-object: ERROR: ***.o: kpatch_create_patches_sections: 2294: lookup_global_symbol *** This patch add support for patching weak function. Signed-off-by: Li Bin <huawei.libin@huawei.com>
Member
|
Instead of creating a new lookup_weak_global_symbol() function, how about just adding the WEAK check to lookup_global_symbol()? |
Contributor
Author
|
Yes, if the two patch is exactly correct, and can be merged together, we can just adding the WEAK check to lookup_global_symbol. Thanks. |
Member
|
Yes, otherwise it looks right to me, so if you can rebase them into a single commit with the change to lookup_global_symbol, I'll give it a 👍 . Thanks for the fix! |
Contributor
Author
|
OK, I will do it and create a new pull request. Thanks. |
libin2015
force-pushed
the
support-weak-function
branch
2 times, most recently
from
42a763c to
795de31
Compare
Member
|
Continued with #508. (next time, please rebase and force push the existing branch instead of opening a new pull request) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.