kpatch-build cleanups#759
Merged
joe-lawrence merged 6 commits intodynup:masterfrom Nov 17, 2017
Merged
Conversation
Fixes: 8dc25d7 ('kpatch-build: let user specify kpatch module name') Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Replace stray spaces with tabs, except in the usage output where tabs don't make much sense. Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
This can be used for building a kpatch module for a non-running kernel. Note that the correct kernel and debug packages still need to be installed. Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
The current checks never fail, because the first grep in the pipeline doesn't write anything to stdout. Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
When searching for 'Linux version ...' in vmlinux, stop after the first match so that we don't keep reading a potentially huge file. Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Member
|
Looks good, thanks! BTW, next time you don't have to open a new pull request when you make changes. You can reuse the same pull request by force pushing to the original branch. 👍 |
Member
|
This feature worked for me on Fedora 26: |
Merged
Contributor
|
@juergh : the patchset looks good, the speed up in 'kpatch-build: Stop reading vmlinux after the first match' shaves over 10 seconds off the build in my Fedora VM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added --archversion commandline option conflict detection.