Skip to content

Fix minor issues found in PR #1355 review: test description accuracy and doc sync #1361

@dyoshikawa

Description

@dyoshikawa

Background

During the review of PR #1355 ("feat: enable global Codex CLI subagent support"), two low-severity issues were identified. Neither blocks the PR, but they should be addressed in a follow-up to maintain codebase quality.

Details

1. Inaccurate test description string in subagents-processor.test.ts

File: src/features/subagents/subagents-processor.test.ts

The test description reads:

"should return claudecode, codexcli, cursor, factorydroid, and opencode as global-supported targets"

However, the expected array also includes claudecode-legacy. The description should either list all targets or use a more general phrasing (e.g., "should return all global-supported targets").

This is a pre-existing issue that PR #1355 inherited but had the opportunity to fix when updating the description.

2. Documentation sync verification needed

Files: docs/reference/supported-tools.md, skills/rulesync/supported-tools.md

Per project conventions, docs/ and skills/rulesync/ content is synchronized by scripts/sync-skill-docs.ts. In PR #1355, both files were updated manually. It should be verified that running the sync script produces the same result, ensuring the manual edits remain consistent with the automated sync process.

Solution / Next Steps

  • Update the test description in subagents-processor.test.ts to accurately reflect all global-supported targets (including claudecode-legacy), or use a generalized description.
  • Run scripts/sync-skill-docs.ts and confirm that docs/ and skills/rulesync/ remain in sync after the PR feat: enable global Codex CLI subagent support #1355 changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationimprovementmaintainer-scrapRough notes for AI implementation. Not for human eyes.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions