fix: align description fallback pattern across commands, subagents and rules

[saitota]

Accidentally closed PR #1205 by deleting the fork. Recreating with the same diff.

Summary

• Remove description ?? "" and description || "" fallback patterns in commands, subagents and rules to propagate undefined instead of empty string
• Make description field optional (z.optional(z.string())) across all command/subagent schemas for consistency with RulesyncRuleFrontmatterSchema
• Improve cursor-rule.ts truthiness check to use explicit !== undefined && !== null && !== "" guard instead of falsy check
• Add deepRemoveNullishObject edge case test for nested objects with all-null values

Closes #1078

Note

This PR addresses all occurrences of the description ?? "" / description || "" pattern found across the codebase, not just the two files mentioned in the issue #1078 .

References

• fix: prevent empty descriptions from being serialized as YAML null in frontmatter #1070
• Cursor rule generation outputs empty description: when source has no description, breaking re-import #1068

Test plan

• pnpm check
• pnpm test

[dyoshikawa-claw]

/opencode review

[dyoshikawa]

@saitota Thank you. Please fix the points of the AI review.

[saitota]

@dyoshikawa Fixed No1 and No3. PTAL

• No1 (MEDIUM): Removed description = "" in cursor-command.ts
• No2(LOW): Skipped — ?? undefined is needed for null-to-undefined conversion (Kiro JSON)
• No3(LOW): Simplified to if (frontmatter.description) in cursor-rule.ts

[dyoshikawa]

@saitota Thank you!

[saitota]

Okay, I'll handle this.

[saitota]

Fixed finding-1 from 2nd review. PTAL

• Finding-1: Removed description: "" in toRulesyncCommand for kiro, codexcli, cline, kilo
• Finding-12: Skipped — same reasoning as previous review finding-2 (?? undefined is needed for null-to-undefined conversion)

[saitota]

Fixed finding-1/7 from 3rd review. PTAL

• Finding-1/7: Added undefined guard for description in geminicli-command.ts TOML generation to prevent literal "undefined" string output

[github-actions]

✓ Fix verified successfully

The fix for finding-1/7 has been correctly implemented in src/features/commands/geminicli-command.ts:126-129. The TOML generation now properly handles undefined descriptions by checking !== undefined before including the description field.

Verification results:

• ✓ All CI checks pass (pnpm cicheck)
• ✓ 4131 tests passed
• ✓ Code quality checks passed (formatting, linting, type checking)
• ✓ No security issues detected

github run

[dyoshikawa]

@saitota Thank you!