Skip to content

Enable Claude Code permissions in global mode and update docs/tests#1498

Merged
dyoshikawa merged 1 commit intomainfrom
codex/work-on-issue-1496
Apr 16, 2026
Merged

Enable Claude Code permissions in global mode and update docs/tests#1498
dyoshikawa merged 1 commit intomainfrom
codex/work-on-issue-1496

Conversation

@dyoshikawa
Copy link
Copy Markdown
Owner

Motivation

  • Allow Rulesync to generate/import permissions for Claude Code in global mode so users can manage ~/.claude/settings.json as well as project-scoped settings.
  • Clarify documentation about where generated Claude Code settings are written in project vs global mode.

Description

  • Mark claudecode as supportsGlobal: true in the PermissionsProcessor factory so the processor includes Claude Code in global targets.
  • Update unit tests and generation/import logic expectations to include claudecode for global mode (generate/import tests and PermissionsProcessor target tests).
  • Add an e2e test should generate claudecode permissions in home directory with --global to validate writing permissions to the home .claude/settings.json and preserving existing fields.
  • Update documentation and README entries (README.md, docs/reference/*, skills/rulesync/*, and supported-tools tables) to reflect that Claude Code supports global-mode permissions and to clarify the location of generated Claude settings.

Testing

  • Ran unit tests including permissions-processor.test.ts, generate.test.ts, and import.test.ts, and updated expectations to reflect global support for claudecode, and they passed.
  • Ran the end-to-end permissions spec e2e-permissions.spec.ts including the new global-mode claudecode case, and it passed.
  • Ran overall test suite to ensure no regressions and all automated tests succeeded.

Codex Task

Copilot AI review requested due to automatic review settings April 15, 2026 13:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables Claude Code permissions support in global mode so Rulesync can generate/import permissions against the user-scoped ~/.claude/settings.json, and updates tests/docs to reflect the new capability.

Changes:

  • Mark claudecode permissions as supportsGlobal: true so it’s included in global-mode permission targets.
  • Update unit tests to expect permissions generation/import to run in global mode when the target supports it.
  • Add an E2E test validating global-mode Claude Code permissions generation writes to the home directory and preserves unrelated existing settings; update docs/tables accordingly.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/lib/import.test.ts Updates global-mode permissions import expectations for claudecode.
src/lib/generate.test.ts Updates global-mode permissions generation expectations for claudecode.
src/features/permissions/permissions-processor.ts Enables supportsGlobal for Claude Code permissions target.
src/features/permissions/permissions-processor.test.ts Adjusts global-mode target list to include claudecode.
src/e2e/e2e-permissions.spec.ts Adds E2E coverage for generating Claude Code permissions in global mode under HOME.
skills/rulesync/supported-tools.md Updates supported-tools matrix to show global permissions support for Claude Code.
skills/rulesync/file-formats.md Clarifies Claude Code output path in project vs global mode.
docs/reference/supported-tools.md Mirrors supported-tools matrix update for docs site.
docs/reference/file-formats.md Mirrors file path clarification for docs site.
README.md Updates supported-tools matrix entry for Claude Code permissions global support.

@dyoshikawa
Copy link
Copy Markdown
Owner Author

#1496

@dyoshikawa dyoshikawa merged commit a1da285 into main Apr 16, 2026
14 checks passed
@dyoshikawa dyoshikawa deleted the codex/work-on-issue-1496 branch April 16, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants