Enable Claude Code permissions in global mode and update docs/tests#1498
Merged
dyoshikawa merged 1 commit intomainfrom Apr 16, 2026
Merged
Enable Claude Code permissions in global mode and update docs/tests#1498dyoshikawa merged 1 commit intomainfrom
dyoshikawa merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Claude Code permissions support in global mode so Rulesync can generate/import permissions against the user-scoped ~/.claude/settings.json, and updates tests/docs to reflect the new capability.
Changes:
- Mark
claudecodepermissions assupportsGlobal: trueso it’s included in global-mode permission targets. - Update unit tests to expect permissions generation/import to run in global mode when the target supports it.
- Add an E2E test validating global-mode Claude Code permissions generation writes to the home directory and preserves unrelated existing settings; update docs/tables accordingly.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/import.test.ts | Updates global-mode permissions import expectations for claudecode. |
| src/lib/generate.test.ts | Updates global-mode permissions generation expectations for claudecode. |
| src/features/permissions/permissions-processor.ts | Enables supportsGlobal for Claude Code permissions target. |
| src/features/permissions/permissions-processor.test.ts | Adjusts global-mode target list to include claudecode. |
| src/e2e/e2e-permissions.spec.ts | Adds E2E coverage for generating Claude Code permissions in global mode under HOME. |
| skills/rulesync/supported-tools.md | Updates supported-tools matrix to show global permissions support for Claude Code. |
| skills/rulesync/file-formats.md | Clarifies Claude Code output path in project vs global mode. |
| docs/reference/supported-tools.md | Mirrors supported-tools matrix update for docs site. |
| docs/reference/file-formats.md | Mirrors file path clarification for docs site. |
| README.md | Updates supported-tools matrix entry for Claude Code permissions global support. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
~/.claude/settings.jsonas well as project-scoped settings.Description
claudecodeassupportsGlobal: truein thePermissionsProcessorfactory so the processor includes Claude Code in global targets.claudecodefor global mode (generate/importtests andPermissionsProcessortarget tests).should generate claudecode permissions in home directory with --globalto validate writing permissions to the home.claude/settings.jsonand preserving existing fields.README.md,docs/reference/*,skills/rulesync/*, and supported-tools tables) to reflect that Claude Code supports global-mode permissions and to clarify the location of generated Claude settings.Testing
permissions-processor.test.ts,generate.test.ts, andimport.test.ts, and updated expectations to reflect global support forclaudecode, and they passed.e2e-permissions.spec.tsincluding the new global-mode claudecode case, and it passed.Codex Task