Skip to content

WIP: Fix Make functions use null as a way to delete value#24

Open
Aviortheking wants to merge 7 commits intomasterfrom
make-functions-use-null-23
Open

WIP: Fix Make functions use null as a way to delete value#24
Aviortheking wants to merge 7 commits intomasterfrom
make-functions-use-null-23

Conversation

@Aviortheking
Copy link
Member

@Aviortheking Aviortheking commented Apr 10, 2021

Fixes #23

Signed-off-by: Avior <florian.bouillon@delta-wings.net>
@Aviortheking Aviortheking changed the title WIP: Fix Make functions use null as a way to delete value (#23) WIP: Fix Make functions use null as a way to delete value Apr 10, 2021
@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #24 (c45351d) into master (7ce7daf) will decrease coverage by 2.34%.
The diff coverage is 82.60%.

❗ Current head c45351d differs from pull request most recent head 580da76. Consider uploading reports for the commit 580da76 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   95.41%   93.06%   -2.35%     
==========================================
  Files           3        3              
  Lines         327      303      -24     
  Branches       87       87              
==========================================
- Hits          312      282      -30     
- Misses         15       21       +6     
Impacted Files Coverage Δ
packages/url-manager/src/URLManager.ts 91.62% <82.60%> (-2.96%) ⬇️
packages/easy-sitemap/src/Sitemap.ts 87.75% <0.00%> (-0.49%) ⬇️
packages/object-util/src/ObjectUtil.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce264b2...580da76. Read the comment docs.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.3% 76.3% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make functions use null as a way to delete value

1 participant