Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 88.62% 89.12% +0.49%
==========================================
Files 27 27
Lines 2760 2776 +16
==========================================
+ Hits 2446 2474 +28
+ Misses 314 302 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the reliability of the Java version check subprocess script in the
rJavaEnvpackage, specifically addressing issues when.libPaths()contains multiple paths. The main change refactors how the wrapper script is constructed to avoid duplication and malformed syntax, and adds a targeted regression test to ensure correctness.Refactor and reliability improvements:
._java_version_check_rjava_impl_originalinR/java_env.Rto correctly handle multi-line.libPaths()values by introducing a helper (deparse_collapse) and ensuring function definitions and library paths are included only once and with proper syntax. This prevents duplication and malformed closing parentheses in the generated script.Testing and regression coverage:
tests/testthat/test-java_env_subprocess_regression.Rthat mocks.libPaths()with multiple paths and validates that the generated script contains the correct function definitions and library path syntax, with no duplication or syntax errors.Solves #100 .