Skip to content

Conversation

@cxddlmu
Copy link
Contributor

@cxddlmu cxddlmu commented Jan 16, 2019

change the class definition way of MagicGrid

@e-oj
Copy link
Owner

e-oj commented Jan 16, 2019

Based on this template I think it might work if you leave the "declare" statement and add an "export" statement like:

export = MagicGrid

declare class MagicGrid { .... }

Try that. If it works then update this PR, else I'll merge as is. Let me know how it goes.

@e-oj
Copy link
Owner

e-oj commented Jan 21, 2019

@cxddlmu Any updates?

@cxddlmu
Copy link
Contributor Author

cxddlmu commented Jan 22, 2019

sorry for updating late.
i have tried your suggestion. It works. But you should remove export in below code, because export assignment can not be used with other export
export interface MagicGridProps

@cxddlmu
Copy link
Contributor Author

cxddlmu commented Jan 22, 2019

this below change will better solution
export default MagicGrid
declare class MagicGrid { .... }

@hk-skit
Copy link

hk-skit commented Jan 24, 2019

Hi @e-oj,

Can you please merge this PR? This change required for magic-grid to work with the angular eco-system.

@e-oj e-oj merged commit 011cc9d into e-oj:dev Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants