-
Notifications
You must be signed in to change notification settings - Fork 1
feat: filesystem navigator #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 61a9dd9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
OmerGronich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move filesystem-navigator and toolbar to workspace-manager/src/lib/ui instead of features
and also filesystem-navigator-utils should either be deleted or at the very least moved to data-access, and the word "utils" should be removed from the name
.../workspace-manager/src/lib/features/filesystem-navigator/filesystem-navigator.component.html
Outdated
Show resolved
Hide resolved
.../workspace-manager/src/lib/features/filesystem-navigator/filesystem-navigator.component.html
Outdated
Show resolved
Hide resolved
libs/workspace-manager/src/lib/features/filesystem-navigator/filesystem-navigator.component.ts
Outdated
Show resolved
Hide resolved
libs/workspace-manager/src/lib/features/filesystem-navigator/filesystem-navigator.component.ts
Outdated
Show resolved
Hide resolved
libs/workspace-manager/src/lib/features/filesystem-navigator/filesystem-navigator.component.ts
Outdated
Show resolved
Hide resolved
libs/workspace-manager/src/lib/features/filesystem-navigator/filesystem-navigator.component.ts
Outdated
Show resolved
Hide resolved
...manager/src/lib/features/filesystem-navigator/services/filesystem-navigator-utils.service.ts
Outdated
Show resolved
Hide resolved
libs/workspace-manager/src/lib/consts/angular-logo-img.const.ts
Outdated
Show resolved
Hide resolved
libs/workspace-manager/src/lib/data-access/workspace-manager-api.service.ts
Outdated
Show resolved
Hide resolved
libs/workspace-manager/src/lib/data-access/workspace-manager-api.service.ts
Show resolved
Hide resolved
.../filesystem-navigator/filesystem-navigator-toolbar/filesystem-navigator-toolbar.component.ts
Outdated
Show resolved
Hide resolved
|
regarding the visuals of it, the toolbar should look like a filesystem path, you should change the |
@OmerGronich WDYT about replacing the folder icon with the angular logo instead of adding the angular logo at the end ? |
Not bad IMO, @Danieliverant what do you think? |
I really like it |
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 61.88% 64.34% +2.45%
==========================================
Files 72 77 +5
Lines 551 589 +38
Branches 27 27
==========================================
+ Hits 341 379 +38
Misses 209 209
Partials 1 1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |

PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
add file-system navigator
What is the current behavior?
Issue Number: #5
What is the new behavior?
Does this PR introduce a breaking change?
Other information