Skip to content

feat: 🎸 async executors on be#98

Merged
agroupp merged 1 commit intomasterfrom
arthur/async-executors
Mar 12, 2023
Merged

feat: 🎸 async executors on be#98
agroupp merged 1 commit intomasterfrom
arthur/async-executors

Conversation

@agroupp
Copy link
Copy Markdown
Collaborator

@agroupp agroupp commented Mar 10, 2023

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

##Asynchronous tasks for executors API

  • POST /executors with "command" and args dictionary in the body. Returns PID of the started task
  • GET /executors/status?pid= Returns the task status and output. It can be used for polling to fill the "terminal" window on FE.
  • GET /executors Returns list of tasks with their brief status information (something like ps -aux)
  • DELETE /executors with { pid: } in the body. Stops the task. Works on win only for now, need to work on it for Mac and Linux.

@agroupp agroupp added the server label Mar 10, 2023
@agroupp agroupp requested a review from a team March 10, 2023 12:12
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Mar 10, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 01164fb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2023

Codecov Report

Merging #98 (01164fb) into master (a8d9f84) will decrease coverage by 6.98%.
The diff coverage is 33.03%.

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   68.02%   61.05%   -6.98%     
==========================================
  Files          64       72       +8     
  Lines         441      552     +111     
  Branches       18       27       +9     
==========================================
+ Hits          300      337      +37     
- Misses        140      214      +74     
  Partials        1        1              
Flag Coverage Δ *Carryforward flag
cli-daemon 49.35% <33.03%> (-6.49%) ⬇️
cli-gui 89.83% <ø> (ø)
configuration 100.00% <ø> (ø) Carriedforward from a8d9f84
executors 100.00% <ø> (ø) Carriedforward from a8d9f84
generators 71.42% <ø> (ø)
shared ∅ <ø> (∅)
ui 100.00% <ø> (ø) Carriedforward from a8d9f84
workspace-manager 86.36% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
apps/cli-daemon/src/app/utils/string-to-array.ts 50.00% <0.00%> (ø)
apps/cli-daemon/src/app/executors/string-buffer.ts 16.66% <16.66%> (ø)
.../cli-daemon/src/app/executors/executors.service.ts 30.43% <30.43%> (ø)
apps/cli-daemon/src/app/executors/child-process.ts 31.57% <31.57%> (ø)
...i-daemon/src/app/executors/executors.controller.ts 34.78% <34.78%> (ø)
...ps/cli-daemon/src/app/executors/child-processes.ts 40.00% <40.00%> (ø)
...rc/app/executors/utils/spawned-process-cmd-line.ts 50.00% <50.00%> (ø)
apps/cli-daemon/src/app/executors/utils/index.ts 100.00% <100.00%> (ø)
apps/cli-daemon/testing/executors-service.mock.ts 100.00% <100.00%> (ø)
apps/cli-daemon/testing/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@agroupp agroupp force-pushed the arthur/async-executors branch from bc45051 to 01164fb Compare March 12, 2023 09:17
@agroupp agroupp merged commit 68ca9e2 into master Mar 12, 2023
@agroupp agroupp deleted the arthur/async-executors branch March 12, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants