Skip to content

Implementation of multi alpha/beta for proton plans with TOPAS#884

Merged
wahln merged 12 commits intoe0404:devfrom
SimonaFa:dev_TOPASinterface_multiAlphaBeta
Mar 3, 2026
Merged

Implementation of multi alpha/beta for proton plans with TOPAS#884
wahln merged 12 commits intoe0404:devfrom
SimonaFa:dev_TOPASinterface_multiAlphaBeta

Conversation

@SimonaFa
Copy link
Copy Markdown
Contributor

@SimonaFa SimonaFa commented Feb 2, 2026

First concept for enabling a Monte Carlo recalculation using different alpha/beta for different structures. The implementation works for protons when using the default TOPAS scorers (MCN, WED), but needs to be extended for carbon in the future, to include the tabulated models which are currently not available on this branch.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 72.38095% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.91%. Comparing base (66e2afa) to head (e956cd3).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...atRad/doseCalc/+DoseEngines/matRad_TopasMCEngine.m 72.81% 28 Missing ⚠️
matRad/planAnalysis/matRad_compareDose.m 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #884      +/-   ##
==========================================
+ Coverage   54.80%   54.91%   +0.11%     
==========================================
  Files         310      310              
  Lines       20040    20115      +75     
==========================================
+ Hits        10982    11046      +64     
- Misses       9058     9069      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2026

Test Results

    3 files  ±0      3 suites  ±0   44m 31s ⏱️ +26s
  331 tests +1    331 ✅ +1  0 💤 ±0  0 ❌ ±0 
1 089 runs  +3  1 084 ✅ +3  5 💤 ±0  0 ❌ ±0 

Results for commit e956cd3. ± Comparison against base commit 66e2afa.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@wahln wahln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, this looks really great. I will run a Copilot Review to see if there's anything substantial it catches.

Is there anything we could do do get more test coverage? For TOPAS, we only check if the files are written I think.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables Monte Carlo (TOPAS) proton plan recalculation with multiple structure-dependent photon LQ parameters (α/β), introducing “CellType” variants of TOPAS RBE scorers and partial postprocessing support.

Changes:

  • Extend TOPAS MC engine to derive multiple (αx, βx) pairs from cst and emit per-CellType scorer variants.
  • Update RBExDose parameter initialization and begin mapping scorer outputs back into dij per CellType.
  • Prevent zero-width dose-difference display range in matRad_compareDose.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File Description
matRad/planAnalysis/matRad_compareDose.m Avoids invalid [0 0] dose-difference display window when cubes are identical.
matRad/doseCalc/+DoseEngines/matRad_TopasMCEngine.m Adds multi-(α/β) handling for TOPAS proton RBE scorers and attempts CellType-aware readback into dij.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread matRad/doseCalc/+DoseEngines/matRad_TopasMCEngine.m Outdated
Comment thread matRad/doseCalc/+DoseEngines/matRad_TopasMCEngine.m Outdated
Comment thread matRad/doseCalc/+DoseEngines/matRad_TopasMCEngine.m
Comment thread matRad/doseCalc/+DoseEngines/matRad_TopasMCEngine.m
Comment thread matRad/doseCalc/+DoseEngines/matRad_TopasMCEngine.m Outdated
Comment thread matRad/doseCalc/+DoseEngines/matRad_TopasMCEngine.m Outdated
Comment thread matRad/doseCalc/+DoseEngines/matRad_TopasMCEngine.m
@wahln wahln merged commit 134a6af into e0404:dev Mar 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants