Merged
Conversation
Deploying framework-tracker with
|
| Latest commit: |
82060fe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d47eb2a6.framework-tracker.pages.dev |
| Branch Preview URL: | https://cli-stats-ui.framework-tracker.pages.dev |
43081j
reviewed
Mar 15, 2026
| @@ -0,0 +1,10 @@ | |||
| --- | |||
| import { chartDupeDepsData } from '../lib/collections' | |||
Contributor
There was a problem hiding this comment.
can we call this file and related names in full? like DuplicateDependencyChart, chartDuplicateDependencyData, etc
Contributor
|
looks good to me! left one minor nit comment re the wording but its not a blocker. as for your question, i think duplicates showing is fine. we can change it later if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added UI for the e18e CLI output. Currently, this PR adds the following:
Question Should dups deps be on the home page, or is it a little misleading?
Also, the e18e CLI now powers the deps counts soI moved the UI to use that
Checklist
starter-*package, ensure that the deps, and file content matches the output of the metaframeworks recommended starter/default project