Skip to content

docs: show units on comparison charts#216

Open
aqilaziz wants to merge 2 commits into
e18e:mainfrom
aqilaziz:docs-chart-unit-labels-214
Open

docs: show units on comparison charts#216
aqilaziz wants to merge 2 commits into
e18e:mainfrom
aqilaziz:docs-chart-unit-labels-214

Conversation

@aqilaziz
Copy link
Copy Markdown

Summary

  • add explicit unit labels to the shared comparison bar chart header and SVG axis
  • include the unit in the chart accessibility description
  • set clearer unit labels for count-based charts such as dependencies and ops/sec

Testing

  • pnpm exec prettier --check packages/docs/src/components/ComparisonBarChart.astro packages/docs/src/components/DepsChart.astro packages/docs/src/components/ProdDepsChart.astro packages/docs/src/components/DuplicateDependencyChart.astro packages/docs/src/components/SSROpsChart.astro packages/docs/src/lib/types.ts
  • pnpm --filter @framework-tracker/docs type-check
  • pnpm --filter @framework-tracker/docs build
  • git diff --check

Fixes #214

@AlexanderKaran
Copy link
Copy Markdown
Collaborator

@aqilaziz For UX/UI changes can you please add a screen shot or gif of the changes

@aqilaziz
Copy link
Copy Markdown
Author

aqilaziz commented May 12, 2026

Added screenshots for the chart unit labels.

Dev Time charts:

Dev Time chart unit labels

Run Time charts:

Run Time chart unit labels

Validation run:

  • pnpm --filter @framework-tracker/docs type-check
  • pnpm --filter @framework-tracker/docs build

@AlexanderKaran
Copy link
Copy Markdown
Collaborator

Thanks @aqilaziz, look at those screenshots, we now have three units in some places. My fault task was not super clear,

I think it would be best to just remove units from the Graph titles and just have it in the graphs themselves

Copy link
Copy Markdown
Collaborator

@AlexanderKaran AlexanderKaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up other units so its just the unit in the graph, remove from the title for example

@aqilaziz
Copy link
Copy Markdown
Author

Addressed the review feedback by removing units from the chart titles. Units now stay in the chart UI/axis only.

Updated runtime screenshot:

Runtime chart titles without title units

Validation:

  • pnpm exec prettier --check packages/docs/src/components/MPAFPChart.astro packages/docs/src/components/MPAFCPChart.astro packages/docs/src/components/MPAINPChart.astro packages/docs/src/components/SPAFPChart.astro packages/docs/src/components/SPAFCPChart.astro packages/docs/src/components/SPAINPChart.astro packages/docs/src/components/SSROpsChart.astro
  • pnpm --filter @framework-tracker/docs type-check
  • pnpm --filter @framework-tracker/docs build
  • git diff --check

@AlexanderKaran
Copy link
Copy Markdown
Collaborator

@aqilaziz Great work thank you so much

@AlexanderKaran AlexanderKaran self-requested a review May 13, 2026 13:58
@43081j
Copy link
Copy Markdown
Contributor

43081j commented May 13, 2026

is there any way we can put the label on the axis?

really it should look like this:


                 |
                 |
time (ms)        |
                 |
                 |

i think 🤔 or sideways. @AlexanderKaran ?

its an axis label, thats where it'd normally be i think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit on Graphs

3 participants