Skip to content

chore: update typo#125

Merged
43081j merged 2 commits intoe18e:mainfrom
bluwy:patch-1
Jul 29, 2024
Merged

chore: update typo#125
43081j merged 2 commits intoe18e:mainfrom
bluwy:patch-1

Conversation

@bluwy
Copy link
Copy Markdown
Contributor

@bluwy bluwy commented Jul 29, 2024

I believe this part means older projects that aren’t actively maintained (?)

@43081j
Copy link
Copy Markdown
Contributor

43081j commented Jul 29, 2024

i think it is actually right but maybe it could be worded better?

This is a very opinionated list of modules with preferred replacements. Often
these replacements are much lighter or more modern than the modules they are
replacing.

Sometimes these may also be forks of older packages which are actively
maintained (unlike the source module).

these is referring to the replacements, not the source modules. i.e. the replacements may be forks of older unmaintained packages

@bluwy
Copy link
Copy Markdown
Contributor Author

bluwy commented Jul 29, 2024

Ah I see the confusion now. No I think I understand that these refer to the replacements too. I think it comes to this:

When I read the sentence, I assume which are actively maintained (unlike the source module) refers to the older packages, not these. So I'm confused why older packages are still actively maintained.

Maybe we should add a comma before the which? Or I think if others read the way I read too, this PR also works, because it implies these to be more actively maintained.

@43081j
Copy link
Copy Markdown
Contributor

43081j commented Jul 29, 2024

Sometimes these may also be actively maintained forks of older, unmaintained source packages.

maybe this will do better?

@43081j 43081j merged commit 7ab526f into e18e:main Jul 29, 2024
@bluwy bluwy deleted the patch-1 branch July 29, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants