Skip to content

feat: add react-helmet to preferred manifest#413

Merged
43081j merged 10 commits intoe18e:mainfrom
gameroman:react-helmet
Mar 16, 2026
Merged

feat: add react-helmet to preferred manifest#413
43081j merged 10 commits intoe18e:mainfrom
gameroman:react-helmet

Conversation

@gameroman
Copy link
Copy Markdown
Contributor

Closes #185

@gameroman gameroman changed the title feat: add react-helmet to replacements [WIP] feat: add react-helmet to replacements Mar 13, 2026
@gameroman gameroman marked this pull request as ready for review March 13, 2026 09:51
Comment thread docs/modules/react-helmet.md Outdated
@gameroman gameroman requested a review from 43081j March 14, 2026 18:42
@gameroman gameroman changed the title feat: add react-helmet to replacements feat: add react-helmet to preferred manifest Mar 14, 2026
Comment thread manifests/preferred.json Outdated
"react-helmet": {
"type": "module",
"moduleName": "react-helmet",
"replacements": ["react-helmet-async"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we also tell that we can actually just use react without a module maybe this part is important for when it appears in npmx

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure there is a way to do that at the moment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really there's two replacements, so this array isn't quite right.

the first replacement should probably be "react" i guess.

we can figure out nicer ways to present that and infer that it means "no dependency needed" in future

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking in future we could add something like :remove: or :upstreamed: which would that functionality exists in the package for which this is used or something like that

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now we can just add react.

since you are in fact replacing the thing you use with something the "react" module provides

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@43081j 43081j merged commit 2ae35ca into e18e:main Mar 16, 2026
3 checks passed
@gameroman gameroman deleted the react-helmet branch March 16, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React Helmet

3 participants