feat: add react-helmet to preferred manifest#413
Conversation
react-helmet to replacements [WIP]react-helmet to replacements
react-helmet to replacementsreact-helmet to preferred manifest
| "react-helmet": { | ||
| "type": "module", | ||
| "moduleName": "react-helmet", | ||
| "replacements": ["react-helmet-async"], |
There was a problem hiding this comment.
How should we also tell that we can actually just use react without a module maybe this part is important for when it appears in npmx
There was a problem hiding this comment.
Not sure there is a way to do that at the moment
There was a problem hiding this comment.
really there's two replacements, so this array isn't quite right.
the first replacement should probably be "react" i guess.
we can figure out nicer ways to present that and infer that it means "no dependency needed" in future
There was a problem hiding this comment.
I was thinking in future we could add something like :remove: or :upstreamed: which would that functionality exists in the package for which this is used or something like that
There was a problem hiding this comment.
for now we can just add react.
since you are in fact replacing the thing you use with something the "react" module provides
Closes #185