Skip to content

feat: add define-property to native manifest#416

Merged
43081j merged 3 commits intoe18e:mainfrom
gameroman:define-property
Mar 15, 2026
Merged

feat: add define-property to native manifest#416
43081j merged 3 commits intoe18e:mainfrom
gameroman:define-property

Conversation

@gameroman
Copy link
Copy Markdown
Contributor

No description provided.

@43081j
Copy link
Copy Markdown
Contributor

43081j commented Mar 13, 2026

it sounds like it does the same job as Object.defineProperty. i wonder if we need to bother using Reflect at all here

@gameroman
Copy link
Copy Markdown
Contributor Author

I used Reflect.defineProperty as the library mentioned it. Should I add both replacements to the array or just keep Object.defineProperty?

@43081j
Copy link
Copy Markdown
Contributor

43081j commented Mar 14, 2026

you should use object defineproperty.

@gameroman gameroman changed the title feat: add define-property to replacements feat: add define-property to native manifest Mar 14, 2026
Copy link
Copy Markdown
Contributor

@joaopedrodcf joaopedrodcf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@43081j 43081j merged commit a9af5ea into e18e:main Mar 15, 2026
3 checks passed
@gameroman gameroman deleted the define-property branch March 15, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants