feat: add temp package to preferred manifest#453
Conversation
|
given its the same replacements as tempy, we should probably just have one document. do not update the title of the tempy doc, just add a description before the replacements list like "creating temporary files and directories can now be achieved natively in modern engines, making libraries like tempy redundant.". |
|
Should I then instead of diffs make it examples without diffs or should I keep the diffs for |
|
either works. whichever you think is most helpful. in this case i dont have a preference since a diff will still be helpful, but so will a plain usage example. sorry for the non-answer 😄 |
| const tempDirPath = await mkdtemp(join(await realpath(tmpdir()), 'foo-')) // [!code ++] | ||
| ``` | ||
|
|
||
| ```ts |
There was a problem hiding this comment.
this code block needs some context. a description or something. what is it showing us that the earlier one doesn't show?
There was a problem hiding this comment.
It's that one is showing diff for tempy and the second one for temp
There was a problem hiding this comment.
currently its just a standalone code block with no explanation. we should add some text before it, or not have it.
we haven't yet decided how to handle multiple target modules in one doc. this is the first time. so im not sure if we should bother as it feels like a discussion is needed
2 participants
Closes #339