Skip to content

docs: updated pr template. issue template. and support documentation#458

Merged
43081j merged 10 commits intoe18e:mainfrom
stephansama:feature/pr-issue-templates
Mar 21, 2026
Merged

docs: updated pr template. issue template. and support documentation#458
43081j merged 10 commits intoe18e:mainfrom
stephansama:feature/pr-issue-templates

Conversation

@stephansama
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gameroman gameroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments

Comment thread .github/ISSUE_TEMPLATE/1-replacement.yml Outdated
Comment thread .github/SUPPORT.md Outdated
Comment thread .github/ISSUE_TEMPLATE/config.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/config.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/1-bug.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/1-bug.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/1-bug.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/1-bug.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/1-bug.yml Outdated
@@ -0,0 +1,20 @@
name: Replacement
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we in the replacements ask questions like why you want to replace X to Y, advantages of the package that we are advising to migrate to with a common checklist ?

Copy link
Copy Markdown
Contributor

@gameroman gameroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing left to change, https://github.com/es-tooling/module-replacements/pull/458/changes#r2948172781, and everything else looks good 👍

@stephansama
Copy link
Copy Markdown
Contributor Author

One thing left to change, https://github.com/es-tooling/module-replacements/pull/458/changes#r2948172781, and everything else looks good 👍

thank you sir for taking the time to look at it! i just updated it missed it earlier sorry lol

Comment thread .github/pull_request_template.md Outdated
@stephansama stephansama requested a review from gameroman March 18, 2026 01:41
Comment thread .github/ISSUE_TEMPLATE/1-replacement.yml Outdated
@43081j
Copy link
Copy Markdown
Contributor

43081j commented Mar 21, 2026

thanks so much for taking time to do this 🙏

it is very much needed. i left one minor comment, and do agree it may be nice to have some bullet points when suggesting a new replacement. though i dont want it to be too strict as it'd be better that people have to word this themselves rather than a box checking exercise

@stephansama
Copy link
Copy Markdown
Contributor Author

thanks so much for taking time to do this 🙏

it is very much needed. i left one minor comment, and do agree it may be nice to have some bullet points when suggesting a new replacement. though i dont want it to be too strict as it'd be better that people have to word this themselves rather than a box checking exercise

for sure sir. im going to address the first issue and attempt the second comment as well 🫡

@stephansama
Copy link
Copy Markdown
Contributor Author

stephansama commented Mar 21, 2026

ok @43081j. i have update the pr again sir 🫡 please let me know if there are any other issues you would like me to fix in this pr. thank you all for the comments!

@43081j 43081j merged commit 5d2e4a0 into e18e:main Mar 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants