Conversation
joaopedrodcf
approved these changes
Mar 23, 2026
Contributor
|
Looks good |
AlexanderKaran
approved these changes
Mar 23, 2026
|
This is really good. Very clear. |
|
Should we update this to reflect: https://github.com/es-tooling/module-replacements/blob/main/.github/pull_request_template.md |
Contributor
paoloricciuti
left a comment
paoloricciuti
left a comment
There was a problem hiding this comment.
Overall looks good...left a few comments but are mostly minor things
Contributor
Author
|
@paoloricciuti i have updated it per your comments can you have another look? |
Contributor
paoloricciuti
left a comment
paoloricciuti
left a comment
There was a problem hiding this comment.
I'm being veeeeery pedantic so feel free to fuck me off but I've left a couple more comments with suggestions 🧡
Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
gameroman
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description