Fix ignore files in file upload and added tests #1012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2f83444 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
dobrac
approved these changes
Nov 10, 2025
mishushakov
deleted the
fix-file-upload-targz-ignore-and-add-tests-eng-3281
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Ensure file uploads honor ignore patterns (incl. .dockerignore), refactor file discovery/tar streaming in JS/Python SDKs, and add comprehensive tests.
ignorePatterns(merged fromfileIgnorePatternsand.dockerignore) to tar creation, ensuring ignored files aren’t uploaded.getAllFilesForFilesHash->getAllFilesInPathwith optional directory inclusion in both SDKs.tar_file_stream(JS and Python) to build archives fromgetAllFilesInPath, withnoDirRecurseand symlink control.getAllFilesInPath.Nonein Pythonstack_tracesduring build wait.uploadFileand Python async/syncupload_filenow use tar streaming with ignore patterns; JSTemplatewires ignore patterns into uploads.getAllFilesInPathandtar_file_streamin JS and Python, covering ignore patterns, directories, sorting, and symlinks.@e2b/python-sdkande2b(patch).Written by Cursor Bugbot for commit 2f83444. This will update automatically on new commits. Configure here.