Conversation
|
Package ArtifactsBuilt from c6a385f. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.12.2-chore-allow-release-from-prs.0.tgzCLI ( npm install ./e2b-cli-2.7.1-chore-allow-release-from-prs.0.tgzPython SDK ( pip install ./e2b-2.13.2+chore.allow.release.from.prs-py3-none-any.whl |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26ec8281c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
af855d9 to
f6a9a45
Compare
f6a9a45 to
a5d53d0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| - name: Sanitize tag | ||
| id: tag | ||
| run: | | ||
| RAW_TAG="${{ github.event.inputs.tag }}" |
There was a problem hiding this comment.
Script injection via unsanitized workflow dispatch inputs
Low Severity
The rc-validate steps directly interpolate ${{ github.event.inputs.tag }} and ${{ github.event.inputs.preid || github.ref_name }} into shell run: blocks, making them vulnerable to GitHub Actions script injection. A collaborator could craft an input to break out of the double-quoted string and execute arbitrary commands, potentially exfiltrating secrets. The safe env: indirection pattern is already used in pkg_artifacts.yml (line 43–46 of that file) for github.head_ref but wasn't applied here.


Note
Medium Risk
Changes release/publishing workflows and introduces new publishing paths (npm/PyPI), so misconfiguration could publish incorrect candidate versions or tags.
Overview
Adds a new
pkg_artifacts.ymlworkflow that, on PRs, builds/versions/packs the JS SDK and CLI and builds the Python SDK, uploads the resulting artifacts, and posts/updates a PR comment with install commands and a link to the run.Refactors
release.ymlto support a manual candidate mode with validated/sanitizedtag/preid, optional per-package tests (orskip-tests), and publishing via a new reusablepublish_candidates.ymlworkflow (including npm provenance), while removing the oldrelease_candidates.ymlworkflow and simplifying production release preflight gating.Written by Cursor Bugbot for commit a5d53d0. This will update automatically on new commits. Configure here.