Skip to content

Conversation

@0div
Copy link
Contributor

@0div 0div commented Mar 21, 2025

0div and others added 30 commits October 4, 2024 19:58
Co-authored-by: Vasek Mlejnsky <vasek@e2b.dev>
Co-authored-by: Vasek Mlejnsky <vasek@e2b.dev>
Co-authored-by: Vasek Mlejnsky <vasek@e2b.dev>
Co-authored-by: Vasek Mlejnsky <vasek@e2b.dev>
@sitole
Copy link
Member

sitole commented Mar 24, 2025

@0div can you rebase it to make here only your changes?

@ValentaTomas
Copy link
Member

The branch is pretty messy, so I don't think this is simple to do.
We should in the future rebase from the start.

@0div
Copy link
Contributor Author

0div commented Mar 27, 2025

@ValentaTomas, is there a specific cluster against which i can re-test this that has comprehensive beta features?

@0div 0div changed the title Add multi-file upload and less flaky metrics test for 1.2.0 beta.1 release Release 1.2.0 beta.1 SDK Mar 27, 2025
@ValentaTomas
Copy link
Member

@ValentaTomas, is there a specific cluster against which i can re-test this that has comprehensive beta features?

It should be foxtrot right now (and in the future staging).

@ValentaTomas
Copy link
Member

@mishushakov Please review, resolve and merge when ready.
From now on then we should rebase to the beta branch from main to keep the git history clean.

@mishushakov
Copy link
Member

@0div can you update the description? Is this basically a merge main <> beta?

@0div
Copy link
Contributor Author

0div commented Mar 30, 2025

@0div can you update the description? Is this basically a merge main <> beta?

@mishushakov yes, it is essentially a merge of main (a week+ old version of it now) into beta. The description is ment to highlight what features in particular are being added to this release in particular and why.

@mishushakov
Copy link
Member

@0div did you run the tests locally? Besides that, looks good so far, also make sure OpenAPI spec is merged properly and clients are generated

@0div
Copy link
Contributor Author

0div commented Mar 31, 2025

@0div did you run the tests locally? Besides that, looks good so far, also make sure OpenAPI spec is merged properly and clients are generated

@mishushakov tested against foxtrot, made some adjustments, pls take another look

Copy link
Member

@mishushakov mishushakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is safe to merge - please verify also that the the SDKs build locally

@0div
Copy link
Contributor Author

0div commented Apr 2, 2025

  • js-sdk/ pnpm build
  • python-sdk/ poetry build
  • cli/ pnpm build

@mishushakov
Copy link
Member

Okay, I think you're good to go 👍

@0div 0div merged commit 5ee025c into beta Apr 2, 2025
2 checks passed
@0div 0div deleted the add-multifile-and-less-1.2.0-beta.1-release branch April 2, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdk-beta Released in the Beta SDKs version

Projects

None yet

Development

Successfully merging this pull request may close these issues.