Skip to content

Conversation

@ben-fornefeld
Copy link
Member

@ben-fornefeld ben-fornefeld commented Nov 21, 2025

Note

Refactors the sandbox inspect route to a client-driven view, adds client directives across inspect/UI modules, switches to motion/react, and makes JsonPopover button customizable.

  • Inspect:
    • Client View Extraction: Replaces page-level composition with SandboxInspectView that wraps SandboxInspectProvider, Filesystem, and Viewer.
    • Client Components: Adds 'use client' to dir.tsx, file.tsx, node.tsx, parent-dir-item.tsx, and the new view.tsx.
    • Motion: Switches imports to motion/react in frame.tsx and stopped-banner.tsx.
  • Header/UI:
    • JsonPopover: Converted to client component and supports buttonProps to customize trigger; metadata.tsx updated to use it instead of a direct Button.
  • Metrics:
    • Dependency Fix: Includes lastMetrics in total useMemo deps in resource-usage-client.tsx.
  • Clients:
    • Marks Supabase browser client (src/lib/clients/supabase/client.ts) as a client module.

Written by Cursor Bugbot for commit b126ae2. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Nov 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web Ready Ready Preview Comment Nov 21, 2025 1:56pm
web-juliett Ready Ready Preview Comment Nov 21, 2025 1:56pm

e.preventDefault()
setIsOpen(true)
}}
{...buttonProps}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Event handlers in buttonProps override critical popover handlers

The {...buttonProps} spread at line 52 occurs after hardcoded onClick and onDoubleClick handlers (lines 42-50). If buttonProps contains these event properties, they will silently override the essential handlers that call stopPropagation(), preventDefault(), and set isOpen(true). This breaks the popover's functionality. The handlers should be merged or buttonProps should be placed before the hardcoded handlers to allow them to take precedence.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected

@ben-fornefeld ben-fornefeld merged commit c62a9e7 into main Nov 21, 2025
6 checks passed
@ben-fornefeld ben-fornefeld deleted the fix-minified-react-rsc-bundling-error branch November 21, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard sandboxes details crash

4 participants