Skip to content

Chore: Remove sdk reference proxying#270

Merged
ben-fornefeld merged 3 commits intomainfrom
chore/remove-sdk-reference-proxying
Mar 13, 2026
Merged

Chore: Remove sdk reference proxying#270
ben-fornefeld merged 3 commits intomainfrom
chore/remove-sdk-reference-proxying

Conversation

@ben-fornefeld
Copy link
Copy Markdown
Member

@ben-fornefeld ben-fornefeld commented Mar 13, 2026

Note

Medium Risk
Changes rewrite/sitemap behavior for /docs/sdk-reference paths, which can affect production routing and SEO indexing if misconfigured. Test coverage was added/updated, but incorrect domain/path config could still cause broken docs links or missing sitemap entries.

Overview
Stops treating the SDK reference as a separately proxied site: removes SDK_REFERENCE_DOMAIN and its middleware rewrite rule, relying on the main DOCUMENTATION_DOMAIN for /docs/* rewrites.

Updates sitemap generation to not include SDK reference URLs by introducing SITEMAP_EXCLUDE_CONFIG and filtering out excluded path prefixes when merging external sitemaps; adds a unit test asserting /docs/sdk-reference* is omitted. Integration tests were updated to assert middleware rewrites send docs traffic (including /docs/sdk-reference/*) to the docs host.

Written by Cursor Bugbot for commit 5181544. This will update automatically on new commits. Configure here.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Mar 13, 2026 5:37am
web-juliett Ready Ready Preview, Comment Mar 13, 2026 5:37am

Request Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f5d12bcb5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@@ -1,9 +1,6 @@
import type { DomainConfig } from '@/types/rewrites.types'

export const LANDING_PAGE_DOMAIN = 'www.e2b-landing-page.com'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Re-export SDK_REFERENCE_DOMAIN or remove remaining imports

Removing SDK_REFERENCE_DOMAIN from @/configs/rewrites breaks the existing named import in src/app/sitemap.ts:13-17, which is still used to build the sites list (src/app/sitemap.ts:60). In environments that compile or bundle the sitemap route, this causes a module export/import mismatch (SDK_REFERENCE_DOMAIN no longer exported), so the app cannot build or serve that route until the consumer is updated in the same change.

Useful? React with 👍 / 👎.

@ben-fornefeld ben-fornefeld merged commit e4a1929 into main Mar 13, 2026
11 checks passed
@ben-fornefeld ben-fornefeld deleted the chore/remove-sdk-reference-proxying branch March 13, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants