Chore: Remove sdk reference proxying#270
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f5d12bcb5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,9 +1,6 @@ | |||
| import type { DomainConfig } from '@/types/rewrites.types' | |||
|
|
|||
| export const LANDING_PAGE_DOMAIN = 'www.e2b-landing-page.com' | |||
There was a problem hiding this comment.
Re-export SDK_REFERENCE_DOMAIN or remove remaining imports
Removing SDK_REFERENCE_DOMAIN from @/configs/rewrites breaks the existing named import in src/app/sitemap.ts:13-17, which is still used to build the sites list (src/app/sitemap.ts:60). In environments that compile or bundle the sitemap route, this causes a module export/import mismatch (SDK_REFERENCE_DOMAIN no longer exported), so the app cannot build or serve that route until the consumer is updated in the same change.
Useful? React with 👍 / 👎.
Note
Medium Risk
Changes rewrite/sitemap behavior for
/docs/sdk-referencepaths, which can affect production routing and SEO indexing if misconfigured. Test coverage was added/updated, but incorrect domain/path config could still cause broken docs links or missing sitemap entries.Overview
Stops treating the SDK reference as a separately proxied site: removes
SDK_REFERENCE_DOMAINand its middleware rewrite rule, relying on the mainDOCUMENTATION_DOMAINfor/docs/*rewrites.Updates sitemap generation to not include SDK reference URLs by introducing
SITEMAP_EXCLUDE_CONFIGand filtering out excluded path prefixes when merging external sitemaps; adds a unit test asserting/docs/sdk-reference*is omitted. Integration tests were updated to assert middleware rewrites send docs traffic (including/docs/sdk-reference/*) to the docs host.Written by Cursor Bugbot for commit 5181544. This will update automatically on new commits. Configure here.