chore: remove dead LOKI_* env vars and deduplicate OTEL_SERVICE_NAME#307
Conversation
…in .env.example Co-Authored-By: ben@e2b.dev <ben@e2b.dev>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
LGTM — straightforward .env.example cleanup, no application code affected.
Extended reasoning...
Overview
This PR only modifies .env.example, removing four LOKI_* variables and a duplicate OTEL_SERVICE_NAME entry. No application code, build configuration, or runtime behavior is affected.
Security risks
None. .env.example is purely documentation/template — it has no effect on deployed environments. Removing references to unused variables cannot leak secrets or change auth behavior.
Level of scrutiny
Minimal. This is a documentation-only change. I verified via grep that no source files reference LOKI_* anywhere in the repository, confirming the audit claim in the PR description. The remaining OTEL block is consistent and properly consolidated.
Other factors
The PR description includes a checklist asking the human to verify deployment configs and CI pipelines don't reference the removed vars — that verification is outside this repo, but since the example file is non-authoritative, even if downstream configs still set those vars, nothing breaks.
Summary
Cleans up
.env.examplebased on a codebase audit:Removed dead
LOKI_*env vars (LOKI_SERVICE_NAME,LOKI_HOST,LOKI_USERNAME,LOKI_PASSWORD) — these were listed in.env.examplebut never read anywhere insrc/. Only the OTEL vars are in use.Removed duplicate
OTEL_SERVICE_NAME— it appeared at both line 38 (standalone) and line 54 (under the OTEL Configuration section). Kept the single entry under the consolidated OTEL Configuration block.Notes
This is a
.env.example-only change — no application code was modified.Link to Devin session: https://app.devin.ai/sessions/c654c1eb471d452681b9ba446fcb3269