Skip to content

refactor: replace @vercel/kv with node-redis client#330

Open
drankou wants to merge 2 commits into
mainfrom
refactor-dependency-on-vercelkv-in-favor-of-general-redis-eng-3835
Open

refactor: replace @vercel/kv with node-redis client#330
drankou wants to merge 2 commits into
mainfrom
refactor-dependency-on-vercelkv-in-favor-of-general-redis-eng-3835

Conversation

@drankou
Copy link
Copy Markdown
Contributor

@drankou drankou commented May 15, 2026

Replace @vercel/kv with node-redis. KV stays optional; the
public API (isKvConfigured / pingKv / getKvValue / setKvValue)
is unchanged, so call sites and existing test mocks don't need updates.

@vercel/kv only speaks the Upstash REST API. node-redis works
against any RESP endpoint — local Redis, ElastiCache, Redis Cloud,
Upstash TCP, Vercel KV's KV_URL, Dragonfly, etc.

Env change ⚠️
KV_REST_API_URL + KV_REST_API_TOKEN → single REDIS_URL
(redis:// or rediss://).

@drankou drankou requested a review from ben-fornefeld as a code owner May 15, 2026 14:16
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 15, 2026

ENG-3835

@cla-bot cla-bot Bot added the cla-signed label May 15, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment May 22, 2026 2:22pm
web-juliett Ready Ready Preview, Comment May 22, 2026 2:22pm

Request Review

Comment thread src/core/shared/clients/kv.ts
@ben-fornefeld
Copy link
Copy Markdown
Member

ben-fornefeld commented May 20, 2026

please merge #326 before and re-point this branch to main, we'll have to coordinate deployment on this one with prod environment

@drankou drankou force-pushed the make-redis-optional-for-local-development-eng-3976 branch from e80086f to 08cd97b Compare May 22, 2026 13:48
Base automatically changed from make-redis-optional-for-local-development-eng-3976 to main May 22, 2026 14:18
@drankou drankou force-pushed the refactor-dependency-on-vercelkv-in-favor-of-general-redis-eng-3835 branch from 11d4357 to 0a399a8 Compare May 22, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants