Merged
Conversation
jakubno
reviewed
Feb 9, 2026
build.sh
Outdated
Comment on lines
35
to
39
| if [[ "$TARGET_ARCH" == "arm64" ]]; then | ||
| cp ../configs/arm64/"${version}.config" .config | ||
| else | ||
| cp ../configs/"${version}.config" .config | ||
| fi |
Member
There was a problem hiding this comment.
wouldn't it make sense to simplify
Suggested change
| if [[ "$TARGET_ARCH" == "arm64" ]]; then | |
| cp ../configs/arm64/"${version}.config" .config | |
| else | |
| cp ../configs/"${version}.config" .config | |
| fi | |
| cp ../configs/"$TARGET_ARCH"/"${version}.config" .config |
build.sh
Outdated
| echo "Copying finished build to builds directory" | ||
| mkdir -p "../builds/vmlinux-${version}" | ||
| cp vmlinux "../builds/vmlinux-${version}/vmlinux.bin" | ||
| # Output path: arm64 builds go into a subdirectory to distinguish from x86_64 |
Member
There was a problem hiding this comment.
you could simplify here, if you change as suggested
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
- Move x86_64 configs to configs/x86_64/ (keep legacy configs/ for now)
- Add arm64 configs in configs/arm64/ (Firecracker reference + NFS v3, WireGuard, NFSD)
- build.sh: TARGET_ARCH env var, configs from configs/{arch}/, cross-compile support
- x86_64 outputs to both legacy path and x86_64/ subdir for backwards compat
- GH Action: matrix build for both architectures, merged artifacts
Output structure:
builds/vmlinux-{ver}/vmlinux.bin # x86_64 legacy (backwards compat)
builds/vmlinux-{ver}/x86_64/vmlinux.bin # x86_64 new
builds/vmlinux-{ver}/arm64/vmlinux.bin # arm64 new
tomassrnka
force-pushed
the
arm64-support
branch
from
cb000d4 to
8f588da
Compare
Member
Author
|
6 tasks
jakubno
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configs/arm64/) based on upstream Firecracker aarch64 reference config, with E2B-specific additions (NFS v3, WireGuard, NFSD)build.sh:TARGET_ARCHenv var (x86_64default,arm64), cross-compiles viagcc-aarch64-linux-gnuwhen building on x86_64 hostsMakefile:build-arm64convenience targetarm64 kernels output to
builds/vmlinux-{version}/arm64/vmlinux.bin, so GCS gets:Test plan
file vmlinux.bin→ELF 64-bit LSB ... ARM aarch64Note
Medium Risk
Changes the kernel build/publish pipeline and output layout, so misconfiguration could break CI releases or downstream consumers despite legacy x86_64 compatibility handling.
Overview
Adds ARM64 kernel build support by introducing
configs/arm64/*and updatingbuild.shto build per-architecture viaTARGET_ARCH(including optional cross-compilation on x86_64 hosts).Updates the GitHub Actions workflow to run a build matrix for
x86_64andarm64, upload per-arch artifacts, then onmaindownload/merge those artifacts and publish to GCS and GitHub Releases with arch-aware asset naming while keeping legacy x86_64 output paths for compatibility. Also adds amake build-arm64convenience target.Written by Cursor Bugbot for commit 8f588da. This will update automatically on new commits. Configure here.