Push firecracker to all environments on release#19
Conversation
PR SummaryMedium Risk Overview Artifact checks were simplified. Reviewed by Cursor Bugbot for commit 063aa95. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 063aa95. Configure here.
|
|
||
| deploy: | ||
| needs: [validate, publish] | ||
| if: needs.validate.outputs.skip_build != 'true' |
There was a problem hiding this comment.
Deploy job is skipped when release already exists
Medium Severity
The deploy job depends on publish via needs and also has if: needs.validate.outputs.skip_build != 'true'. When a release already exists, skip_build is 'true', which causes build and publish to be skipped — and deploy is consequently also skipped. Since deploy downloads directly from the GitHub release (not from build artifacts), it doesn't functionally need the build/publish pipeline. This means if any environment's deploy fails, re-running the workflow won't retry the deploy because the release now exists. The if condition is also redundant since publish being skipped would already cause deploy to be skipped via needs.
Reviewed by Cursor Bugbot for commit 063aa95. Configure here.
|
I think this makes sense as otherwise we need to manually sync the environments. |


No description provided.