Skip to content

Push firecracker to all environments on release#19

Merged
djeebus merged 1 commit intomainfrom
push-firecracker-on-release
Apr 17, 2026
Merged

Push firecracker to all environments on release#19
djeebus merged 1 commit intomainfrom
push-firecracker-on-release

Conversation

@djeebus
Copy link
Copy Markdown
Contributor

@djeebus djeebus commented Apr 17, 2026

No description provided.

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 17, 2026

PR Summary

Medium Risk
Changes the release workflow to deploy artifacts to GCS across multiple environments and alters build-skipping logic to rely only on GitHub release assets, which could cause unintended deploys or missed rebuilds if assets are incomplete.

Overview
Release workflow now deploys to all environments. After publish, a new deploy job runs for staging, juliett, and foxtrot, downloads firecracker-{arch} assets from the GitHub release, and uploads them to gs://$GCP_BUCKET_NAME/firecrackers/... if missing.

Artifact checks were simplified. scripts/validate.py removes GCS existence checks/--gcp-bucket and now skips builds solely based on whether the GitHub release already contains the requested assets; tests were updated accordingly.

Reviewed by Cursor Bugbot for commit 063aa95. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 063aa95. Configure here.


deploy:
needs: [validate, publish]
if: needs.validate.outputs.skip_build != 'true'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy job is skipped when release already exists

Medium Severity

The deploy job depends on publish via needs and also has if: needs.validate.outputs.skip_build != 'true'. When a release already exists, skip_build is 'true', which causes build and publish to be skipped — and deploy is consequently also skipped. Since deploy downloads directly from the GitHub release (not from build artifacts), it doesn't functionally need the build/publish pipeline. This means if any environment's deploy fails, re-running the workflow won't retry the deploy because the release now exists. The if condition is also redundant since publish being skipped would already cause deploy to be skipped via needs.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 063aa95. Configure here.

@ValentaTomas
Copy link
Copy Markdown
Member

I think this makes sense as otherwise we need to manually sync the environments.

@djeebus djeebus marked this pull request as ready for review April 17, 2026 23:57
@djeebus djeebus merged commit eef96dd into main Apr 17, 2026
5 checks passed
@djeebus djeebus deleted the push-firecracker-on-release branch April 17, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants