Skip to content

Filestore cache cleaner performance tweaks#1282

Merged
djeebus merged 3 commits into
mainfrom
clean-nfs-cache-tweaks
Oct 1, 2025
Merged

Filestore cache cleaner performance tweaks#1282
djeebus merged 3 commits into
mainfrom
clean-nfs-cache-tweaks

Conversation

@djeebus
Copy link
Copy Markdown
Contributor

@djeebus djeebus commented Oct 1, 2025

  • delete 900 files per loop (up from 100)
  • only remove a single file entry from cache, not the whole listing

Note

Adds configurable filestore cleanup (disk target, dry-run, files/deletions per loop) and updates cleaner to remove single cache entries; aligns Nomad job/CLI flags.

  • IaC (Terraform/Nomad):
    • Filestore cleanup config: Replace filestore_max_disk_usage_target with filestore_cache_cleanup_disk_usage_target and add filestore_cache_cleanup_dry_run, filestore_cache_cleanup_files_per_loop, filestore_cache_cleanup_deletions_per_loop in iac/provider-gcp/* with validations/defaults.
    • Nomad job args: Update jobs/clean-nfs-cache.hcl to parameterize --dry-run, add --files-per-iteration and --deletions-per-iteration, and pass new vars in nomad/clean-nfs-cache.tf.
  • Orchestrator (clean-nfs-cache):
    • CLI flags: Rename --max-files-per-iteration to --deletions-per-iteration.
    • Cache behavior: ListingCache.Decache now removes only the specific file from the cached directory listing; add removeByIndex helper.
    • Tests: Add unit tests for Decache and removeByIndex.

Written by Cursor Bugbot for commit ce362f5. This will update automatically on new commits. Configure here.

- delete 900 files per loop (up from 100)
- only remove a single file entry from cache, not the whole listing
@e2b-request-same-site-reviewers e2b-request-same-site-reviewers Bot requested review from tomassrnka and removed request for ValentaTomas, dobrac and jakubno October 1, 2025 18:58
@djeebus djeebus changed the title some performance tweaks to the cache cleaner: Filestore cache cleaner performance tweaks Oct 1, 2025
@djeebus djeebus added the improvement Improvement for current functionality label Oct 1, 2025
@ValentaTomas ValentaTomas self-assigned this Oct 1, 2025
@djeebus djeebus merged commit 28d5d6b into main Oct 1, 2025
25 checks passed
@djeebus djeebus deleted the clean-nfs-cache-tweaks branch October 1, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement for current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants