Skip to content

Improve test time is synced#1286

Merged
jakubno merged 3 commits into
mainfrom
improve-test-time-is-synced
Oct 2, 2025
Merged

Improve test time is synced#1286
jakubno merged 3 commits into
mainfrom
improve-test-time-is-synced

Conversation

@jakubno
Copy link
Copy Markdown
Member

@jakubno jakubno commented Oct 2, 2025

  • date %s is truncating the time to seconds -> it could happen that there was 0.999 and in local 1.001 and the test failed
  • Increase the wait time and make the test little bit more relaxed

Note

Increase delay, use millisecond-precision date, and widen tolerance to reduce flaky time sync failures.

  • Tests (tests/periodic-test/time-is-synchronized/index.ts):
    • Increase sleep from 5s to 15s to create a clearer time delta.
    • Use millisecond-precision timestamp (date +%s%3N) and parse as float, then divide by 1000.
    • Relax comparison threshold from 1s to 2s.

Written by Cursor Bugbot for commit eac2d7e. This will update automatically on new commits. Configure here.

@jakubno jakubno requested a review from ValentaTomas as a code owner October 2, 2025 08:20
@jakubno jakubno added the bug Something isn't working label Oct 2, 2025
@jakubno jakubno requested a review from dobrac as a code owner October 2, 2025 08:20
@e2b-request-same-site-reviewers e2b-request-same-site-reviewers Bot requested review from sitole and removed request for ValentaTomas and dobrac October 2, 2025 08:20
@jakubno jakubno enabled auto-merge (squash) October 2, 2025 08:29
@jakubno jakubno merged commit 9fbd1d6 into main Oct 2, 2025
25 checks passed
@jakubno jakubno deleted the improve-test-time-is-synced branch October 2, 2025 08:37
ValentaTomas pushed a commit that referenced this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants