-
Notifications
You must be signed in to change notification settings - Fork 217
Rewrite the rest of queries to SQLC #1527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
76fb851 to
bf15979
Compare
💡 Codex Reviewinfra/packages/api/internal/template/register_build.go Lines 244 to 247 in 76fb851
This branch assumes ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| @@ -0,0 +1,11 @@ | |||
| -- name: CheckAliasConflictsWithTemplate :one | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put it under templat-aliases or something? I think folder aliases can be confusing
# Conflicts: # packages/api/internal/handlers/deprecated_template_request_build.go # packages/api/internal/handlers/sandbox_kill.go # packages/api/internal/handlers/template_request_build_v3.go # packages/api/internal/orchestrator/pause_instance.go # packages/api/internal/template/register_build.go # packages/shared/pkg/models/envbuild.go # packages/shared/pkg/models/envbuild/where.go # packages/shared/pkg/models/envbuild_create.go # packages/shared/pkg/models/envbuild_update.go # packages/shared/pkg/models/migrate/schema.go # packages/shared/pkg/models/mutation.go # packages/shared/pkg/schema/build.go
Co-authored-by: Jiri Sveceny <jiri.sveceny@icloud.com>
9107af9 to
2a19d71
Compare
Note
Replaces Ent ORM with a new sqlc-based data layer and typed models, adds SQL query files and DB client, updates API/handlers and tests accordingly, and removes legacy generated code.
entgogenerated model code (packages/shared/pkg/models/*,migrate,predicate,runtime, etc.) with SQLC-backed queries and typed models.packages/db/queries/*(e.g.,create_template.sql,create_alias.sql,get_snapshot_builds.sql) andpackages/db/typesfor typed enums/structs.packages/shared/pkg/db/client.goand related DB error handling.packages/api/internal/*) to use the new DB client/types.packages/db/tests/*,packages/apitests) and switch enum references (e.g.,envbuild.Status*→dbtypes.BuildStatus*).go.mod/go.sumandMakefilefor new dependencies.envbuild_*,snapshot_*,team_*,user_*,predicate,runtime, etc.).Written by Cursor Bugbot for commit e154e2c. This will update automatically on new commits. Configure here.