Cleanup connections handling #1535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup connections handling in the orchestrator proxy and add more logs to the template builder to catch connection problems.
Note
Adds a keep-alives toggle to proxy/pool (disabled for orchestrator), standardizes sandbox HTTP transport/client, introduces a constant client proxy connection key, improves logging/metrics, and resets connections during template operations.
disableKeepAlivesoption acrossproxy.Newand pool/clients; set totruefor orchestrator proxy andfalsefor client proxy.ForceAttemptHTTP2=falsewhen creating transports.pool.ClientProxyConnectionKeyand use it inclient-proxy.execution.idin proxy pool logs; debug log on client creation.SandboxHttpTransport(keep-alives disabled) andsandboxHttpClient; replace directhttpClientusage inenvd.go,health.go, andmetrics.go.SandboxHttpTransportin template build tools (sandboxtools/command.go,sandboxtools/file.go); drain response body on upload error.envdand on cleanup; add debug/error logs.Written by Cursor Bugbot for commit f02aaf6. This will update automatically on new commits. Configure here.