Skip to content

Conversation

@ValentaTomas
Copy link
Member

@ValentaTomas ValentaTomas commented Nov 24, 2025

Cleanup connections handling in the orchestrator proxy and add more logs to the template builder to catch connection problems.


Note

Adds a keep-alives toggle to proxy/pool (disabled for orchestrator), standardizes sandbox HTTP transport/client, introduces a constant client proxy connection key, improves logging/metrics, and resets connections during template operations.

  • Proxy/Pool:
    • Add disableKeepAlives option across proxy.New and pool/clients; set to true for orchestrator proxy and false for client proxy.
    • Set ForceAttemptHTTP2=false when creating transports.
    • Introduce pool.ClientProxyConnectionKey and use it in client-proxy.
    • Include execution.id in proxy pool logs; debug log on client creation.
  • Sandbox HTTP client:
    • Add SandboxHttpTransport (keep-alives disabled) and sandboxHttpClient; replace direct httpClient usage in envd.go, health.go, and metrics.go.
    • Use SandboxHttpTransport in template build tools (sandboxtools/command.go, sandboxtools/file.go); drain response body on upload error.
  • Orchestrator Template Builder:
    • Remove proxy connections from pool after restarting envd and on cleanup; add debug/error logs.
  • Metrics:
    • Client proxy: add observers for pool size and server connections.
  • Tests:
    • Update proxy constructor calls to pass keep-alives flag.

Written by Cursor Bugbot for commit f02aaf6. This will update automatically on new commits. Configure here.

@ValentaTomas ValentaTomas enabled auto-merge (squash) November 24, 2025 09:34
@ValentaTomas ValentaTomas merged commit c35dbd7 into main Nov 24, 2025
27 checks passed
@ValentaTomas ValentaTomas deleted the build-conn branch November 24, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants