Skip to content

fix(logging): record canceled contexts as 499#2176

Merged
dobrac merged 1 commit into
mainfrom
dobrac/fix-canceled-ctx-log-status
Mar 19, 2026
Merged

fix(logging): record canceled contexts as 499#2176
dobrac merged 1 commit into
mainfrom
dobrac/fix-canceled-ctx-log-status

Conversation

@dobrac
Copy link
Copy Markdown
Contributor

@dobrac dobrac commented Mar 19, 2026

Summary

When a context is canceled, the logging middleware now sets the status code to 499 to match the pattern already used in tracing and metrics middlewares. This ensures consistency across all three observability layers.

The redundant canceled context check in the error-level condition has been removed since 499 won't trigger error-level logging anyway.

Related Issues

Fixes the status code inconsistency for canceled requests across logging, metrics, and traces.


Note

Low Risk
Low risk: logging-only behavior change that adjusts the recorded status code for canceled requests and slightly alters log severity decisions without affecting request handling.

Overview
Updates the Gin logging middleware to record client-canceled requests as HTTP 499 and simplifies severity selection by removing the special-case canceled-context check, aligning logged status/severity with other observability layers.

Written by Cursor Bugbot for commit ddc5e70. This will update automatically on new commits. Configure here.

When a context is canceled, set the status code to 499 to match the pattern
already used in tracing and metrics middlewares. This ensures consistency
across logging, metrics, and traces. Also remove the redundant canceled check
from the error-level condition since 499 won't trigger error-level logging.
Comment thread packages/shared/pkg/middleware/logging.go
@dobrac dobrac enabled auto-merge (squash) March 19, 2026 14:16
@dobrac dobrac merged commit 0f48372 into main Mar 19, 2026
96 of 98 checks passed
@dobrac dobrac deleted the dobrac/fix-canceled-ctx-log-status branch March 19, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants