fix(logging): record canceled contexts as 499#2176
Merged
Conversation
When a context is canceled, set the status code to 499 to match the pattern already used in tracing and metrics middlewares. This ensures consistency across logging, metrics, and traces. Also remove the redundant canceled check from the error-level condition since 499 won't trigger error-level logging.
jakubno
approved these changes
Mar 19, 2026
ValentaTomas
pushed a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a context is canceled, the logging middleware now sets the status code to 499 to match the pattern already used in tracing and metrics middlewares. This ensures consistency across all three observability layers.
The redundant canceled context check in the error-level condition has been removed since 499 won't trigger error-level logging anyway.
Related Issues
Fixes the status code inconsistency for canceled requests across logging, metrics, and traces.
Note
Low Risk
Low risk: logging-only behavior change that adjusts the recorded status code for canceled requests and slightly alters log severity decisions without affecting request handling.
Overview
Updates the Gin logging middleware to record client-canceled requests as HTTP
499and simplifies severity selection by removing the special-case canceled-context check, aligning logged status/severity with other observability layers.Written by Cursor Bugbot for commit ddc5e70. This will update automatically on new commits. Configure here.