Add envd version feature gate#2207
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57cff41976
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
matthewlouisbrockman
left a comment
matthewlouisbrockman
left a comment
There was a problem hiding this comment.
works for me
| return nil, fmt.Errorf("%w: %w", ErrVolumesNotSupported, err) | ||
| // does your envd version support volumes? | ||
| if envdVersion := sharedUtils.DerefOrDefault(env.EnvdVersion, ""); envdVersion == "" { | ||
| logger.L().Warn(ctx, "envd version is unset") |
There was a problem hiding this comment.
Literally no idea. the fields could be empty though, so an error is worth displaying in that case. I've been bit by fields that look like they should be set but weren't here though. Even in this PR, I was using env.EnvdVersion which ended up being never set.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
4 participants
Note
Medium Risk
Sandbox creation now enforces an
envdminimum version for volume mounts, which can start rejecting requests for older or missing template build metadata. This touches request validation/error handling in a core API path and could impact existing templates until rebuilt.Overview
Adds an
envd-version feature gate for persistent volume mounts during sandbox creation: volume mounts are now rejected unless the template build reports anenvdversion >=0.5.8, with clearer client-facing errors when unsupported or unset. Also centralizes theenvdversion constant intopackages/envd/pkgand reuses it in integration seeding, plus minor tooling tweaks (addsmake lintand removes theenvdGoReleaser config).Written by Cursor Bugbot for commit dbe8aec. This will update automatically on new commits. Configure here.