Skip to content

chore: remove unused cache from sandbox catalog#2315

Merged
jakubno merged 3 commits intomainfrom
chore/remove-cache-from-sandbox-catalog
Apr 8, 2026
Merged

chore: remove unused cache from sandbox catalog#2315
jakubno merged 3 commits intomainfrom
chore/remove-cache-from-sandbox-catalog

Conversation

@jakubno
Copy link
Copy Markdown
Member

@jakubno jakubno commented Apr 7, 2026

Remove local cache from redis, it wasn't really used anywhere

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 7, 2026

PR Summary

Medium Risk
Medium risk because this increases Redis read/write traffic and removes a short-lived read-through cache, which could impact latency or load under high request rates. Behavioral correctness should be unchanged, but performance characteristics may shift in production.

Overview
This PR removes the optional local TTL cache from the Redis-backed sandbox catalog and simplifies NewRedisSandboxCatalog to take only a Redis client, updating the orchestrator and client-proxy call sites accordingly. It also deletes the noop/cache implementations and the associated cache-focused tests, leaving all sandbox catalog operations to read/write directly against Redis.

Reviewed by Cursor Bugbot for commit a439670. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4eb6777d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/shared/pkg/sandbox-catalog/catalog_redis.go
Comment thread packages/shared/pkg/sandbox-catalog/catalog_redis.go
Comment thread packages/shared/pkg/sandbox-catalog/catalog_redis.go
@jakubno jakubno merged commit 59ca911 into main Apr 8, 2026
44 checks passed
@jakubno jakubno deleted the chore/remove-cache-from-sandbox-catalog branch April 8, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants