Conversation
ValentaTomas
approved these changes
Apr 13, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d4c252b7f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The seed script failed on repeated runs with a foreign key violation: "envs_teams_envs" on table "envs" (SQLSTATE 23503) This happened because DELETE FROM teams was attempted while rows in envs, snapshots, and volumes still referenced the team via ON DELETE NO ACTION constraints. Similarly, deleting auth.users could be blocked by addons.added_by (also ON DELETE NO ACTION). Fix the deletion order to explicitly remove blocking child rows before deleting the parent team and user: 1. DELETE envs for the team 2. DELETE snapshots for the team 3. DELETE volumes for the team 4. DELETE addons for the user 5. DELETE teams (team_api_keys, users_teams cascade automatically) 6. DELETE auth.users (access_tokens cascade automatically) 7. Re-create user, team, and associated credentials Tables with ON DELETE CASCADE/SET NULL (team_api_keys, users_teams, access_tokens, env_aliases, env_builds, etc.) are cleaned up automatically and do not need explicit deletes. Additionally, inserting into auth.users fires a trigger chain (sync_inserts_to_public_users -> post_user_signup) that auto-creates a default team. Delete that trigger-created team before inserting the seed team to avoid leaving duplicate teams for the same user.
ValentaTomas
pushed a commit
that referenced
this pull request
May 4, 2026
#2383) The seed script failed on repeated runs with a foreign key violation: "envs_teams_envs" on table "envs" (SQLSTATE 23503) This happened because DELETE FROM teams was attempted while rows in envs, snapshots, and volumes still referenced the team via ON DELETE NO ACTION constraints. Similarly, deleting auth.users could be blocked by addons.added_by (also ON DELETE NO ACTION). Fix the deletion order to explicitly remove blocking child rows before deleting the parent team and user: 1. DELETE envs for the team 2. DELETE snapshots for the team 3. DELETE volumes for the team 4. DELETE addons for the user 5. DELETE teams (team_api_keys, users_teams cascade automatically) 6. DELETE auth.users (access_tokens cascade automatically) 7. Re-create user, team, and associated credentials Tables with ON DELETE CASCADE/SET NULL (team_api_keys, users_teams, access_tokens, env_aliases, env_builds, etc.) are cleaned up automatically and do not need explicit deletes. Additionally, inserting into auth.users fires a trigger chain (sync_inserts_to_public_users -> post_user_signup) that auto-creates a default team. Delete that trigger-created team before inserting the seed team to avoid leaving duplicate teams for the same user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seed script failed on repeated runs with a foreign key violation:
"envs_teams_envs" on table "envs" (SQLSTATE 23503)
This happened because DELETE FROM teams was attempted while rows in envs, snapshots, and volumes still referenced the team via ON DELETE NO ACTION constraints. Similarly, deleting auth.users could be blocked by addons.added_by (also ON DELETE NO ACTION).
Fix the deletion order to explicitly remove blocking child rows before deleting the parent team and user:
Tables with ON DELETE CASCADE/SET NULL (team_api_keys, users_teams, access_tokens, env_aliases, env_builds, etc.) are cleaned up automatically and do not need explicit deletes.