-
Notifications
You must be signed in to change notification settings - Fork 283
chore(seed): stop relying on user team provision triggers #2413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ben-fornefeld
wants to merge
6
commits into
main
Choose a base branch
from
remove/user-team-provision-triggers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−14
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f0a6aeb
refactor(db): remove user/team provisioning triggers
ben-fornefeld 0add914
fix(dashboard-api): bootstrap users with admin token only
ben-fornefeld e6a5f2e
Revert "fix(dashboard-api): bootstrap users with admin token only"
ben-fornefeld 32b35d0
chore(seed): narrow branch to seeding updates
ben-fornefeld de1e475
chore(seed): drop stray dashboard spec diff
ben-fornefeld ed6c0b6
chore(seed): drop handler test trigger cleanup
ben-fornefeld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed trigger-created team cleanup causes duplicate teams
High Severity
The
INSERT INTO auth.usersat line 138 still fires thesync_inserts_to_public_userstrigger, which inserts intopublic.users, which fires thepost_user_signuptrigger (moved topublic.usersby migration20260316130000). That trigger creates a default team andusers_teamsrow. The old code explicitly deleted this trigger-created team before creating the seed team, but that cleanup step was removed. TheUpsertPublicUsercall at line 145 is effectively a no-op since the row already exists from the sync trigger, and it doesn't suppresspost_user_signup. The seed now produces two teams and twousers_teamsentries (both withis_default = true), breaking the deterministic single-team setup the seed intends to create.Reviewed by Cursor Bugbot for commit ed6c0b6. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seeding runs either manually on cluster creation or in integration tests. we can life with this until merging #2421 right after