fix(envd): make package build and tests pass on macOS#2605
Conversation
❌ 9 Tests Failed:
View the full list of 12 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Code Review
The Credential field in syscall.SysProcAttr is Linux-specific and will cause compilation errors on Darwin, requiring abstraction into a platform-specific helper. Returning an error from NewCgroup2Manager on non-Linux platforms may prevent the application from initializing on macOS, so returning a non-functional stub manager with a nil error is recommended.
09223af to
38235c4
Compare
Gate Linux-only syscalls (cgroup2, ClockSettime, SysProcAttr cgroup FD fields) behind build tags and provide non-Linux stubs so envd compiles and tests run on darwin. Skip Linux-specific filesystem and /proc tests on other platforms.
38235c4 to
6c3c465
Compare
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
Gate Linux-only syscalls (cgroup2, ClockSettime, SysProcAttr cgroup FD
fields) behind build tags and provide non-Linux stubs so envd compiles
and tests run on darwin. Skip Linux-specific filesystem and /proc tests
on other platforms.