Claude/configure GitHub action #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the PR test workflow into two jobs for better performance: - Fast test job that runs all tests and provides quick feedback - SonarQube analysis job that runs after tests pass Updated workflow name to reflect Kotlin project. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
e5l
changed the title
After converting App.kt to use a top-level main() function, the test was still calling App.main(emptyArray()) which doesn't exist. Updated to call the top-level main() function directly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The pom.xml was configured with Kotlin 2.2.0, but the correct latest stable version is 2.2.21. This was causing build failures as Maven couldn't properly resolve the dependencies. Updated kotlin.version from 2.2.0 to 2.2.21. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed NullPointerException, UnfinishedVerificationException, and InvalidUseOfMatchersException in SergeantTest, CommanderTest, and SoldierTest. The issue was using Mockito's eq() matcher in Kotlin. In Kotlin, eq() returns null (to signal "use this matcher"), but Kotlin's null safety doesn't allow passing null to non-nullable parameters. Solution: Remove the eq() matcher and pass the unit object directly to verify(), since we have the actual instance: - Before: Mockito.verify(mockedVisitor).visit(eq(unit)) - After: Mockito.verify(mockedVisitor).visit(unit) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the CI workflow configuration for the repository, focusing on the test and analysis pipelines. The main changes include renaming and restructuring the Maven workflow to emphasize Kotlin PR tests, splitting the build and analysis steps for better clarity and reliability, and removing the AI-based presubmit review workflow.
Workflow improvements:
Java PR BuildertoKotlin PR Testsin.github/workflows/maven-pr-builder.ymlto better reflect its purpose.build-and-analyzejob into two separate jobs:test(for running tests with Maven and JDK 21, including screen access viaxvfb) andsonar-analysis(for SonarQube analysis, dependent on test completion), improving job clarity and reliability.Presubmit pipeline removal:
.github/workflows/presubmit.ymlworkflow, which previously ran the AI reviewer (presubmit/ai-reviewer@latest) for pull requests and review comments, eliminating automated AI-based code review from the CI process.