Claude/configure GitHub action

.github/workflows/maven-pr-builder.yml

@@ -1,4 +1,4 @@
-name: Java PR Builder
+name: Kotlin PR Tests
 
 on:
   pull_request_target:
@@ -9,10 +9,42 @@ permissions:
   contents: read
 
 jobs:
-  build-and-analyze:
+  test:
+    name: Run Tests
+    runs-on: ubuntu-22.04
+    steps:
+
+      - name: Checkout Code
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+
+      - name: Set up JDK 21
+        uses: actions/setup-java@v4
+        with:
+          java-version: '21'
+          distribution: 'temurin'
+          cache: 'maven'
+
+      - name: Cache local Maven repository
+        uses: actions/cache@v4
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+
+      # Some tests need screen access
+      - name: Install xvfb
+        run: sudo apt-get install -y xvfb
+
+      - name: Build and Test
+        run: xvfb-run ./mvnw clean verify
 
-    name: Build on JDK 21
+  sonar-analysis:
+    name: SonarQube Analysis
     runs-on: ubuntu-22.04
+    needs: test
     steps:
 
       - name: Checkout Code
@@ -33,7 +65,7 @@ jobs:
           path: ~/.m2/repository
           key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
           restore-keys: |
-            ${{ runner.os }}-maven-      
+            ${{ runner.os }}-maven-
 
       # Cache Sonar packages which are used to run analysis and collect metrics
       - name: Cache SonarCloud packages

pom.xml

@@ -69,7 +69,7 @@
     <sonar.projectKey>iluwatar_java-design-patterns</sonar.projectKey>
     <sonar.moduleKey>${project.artifactId}</sonar.moduleKey>
     <sonar.projectName>Java Design Patterns</sonar.projectName>
-      <kotlin.version>2.2.0</kotlin.version>
+      <kotlin.version>2.2.21</kotlin.version>
   </properties>
   <modules>
 

visitor/src/test/java/com/iluwatar/visitor/AppTest.kt

@@ -31,6 +31,6 @@ import org.junit.jupiter.api.Test
 internal class AppTest {
     @Test
     fun shouldExecuteWithoutException() {
-        assertDoesNotThrow { App.main(emptyArray()) }
+        assertDoesNotThrow { main() }
     }
 }

visitor/src/test/java/com/iluwatar/visitor/CommanderTest.kt

@@ -25,11 +25,10 @@
 package com.iluwatar.visitor
 
 import org.mockito.Mockito
-import org.mockito.ArgumentMatchers.eq
 
 /** CommanderTest */
 internal class CommanderTest : UnitTest<Commander>({ children -> Commander(*children) }) {
     override fun verifyVisit(unit: Commander, mockedVisitor: UnitVisitor) {
-        Mockito.verify(mockedVisitor).visit(eq(unit))
+        Mockito.verify(mockedVisitor).visit(unit)
     }
 }

visitor/src/test/java/com/iluwatar/visitor/SergeantTest.kt

@@ -25,11 +25,10 @@
 package com.iluwatar.visitor
 
 import org.mockito.Mockito
-import org.mockito.ArgumentMatchers.eq
 
 /** SergeantTest */
 internal class SergeantTest : UnitTest<Sergeant>({ children -> Sergeant(*children) }) {
     override fun verifyVisit(unit: Sergeant, mockedVisitor: UnitVisitor) {
-        Mockito.verify(mockedVisitor).visit(eq(unit))
+        Mockito.verify(mockedVisitor).visit(unit)
     }
 }

visitor/src/test/java/com/iluwatar/visitor/SoldierTest.kt

@@ -25,11 +25,10 @@
 package com.iluwatar.visitor
 
 import org.mockito.Mockito
-import org.mockito.ArgumentMatchers.eq
 
 /** SoldierTest */
 internal class SoldierTest : UnitTest<Soldier>({ children -> Soldier(*children) }) {
     override fun verifyVisit(unit: Soldier, mockedVisitor: UnitVisitor) {
-        Mockito.verify(mockedVisitor).visit(eq(unit))
+        Mockito.verify(mockedVisitor).visit(unit)
     }
 }