don't self-close void elements #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- self-closing void elements are an xhtrml thing - still preserve them as HTML5 (and most HTML4 parsers) are compatible and some people might prefer <br />
Contributor
Author
|
I'm a bit unsure about preserving the input. It might be better to always produce "correct" output regardless of the input. |
Contributor
|
Yes, I think the way to go is to have the parser be tolerant and eat anything it can understand, but then produce compliant markup of what it parsed. |
devebookingservices
added a commit
that referenced
this pull request
Jan 26, 2016
don't self-close void elements
Contributor
Author
Wait, then we should always output |
Contributor
Author
|
See #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatible and some people might prefer